dalu/uniuri
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixed the same value always generated for 256-divisor chars

Browse Source
This commit is contained in:
Oleg Ivanov 2014-08-10 00:37:31 +10:00
parent 1b691aeab2
commit 28e216136a
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
uniuri.go
View File

@ -56,7 +56,7 @@ func NewLenChars(length int, chars []byte) string {
panic("error reading from random source: " + err.Error()) panic("error reading from random source: " + err.Error())
} }
for _, c := range r { for _, c := range r {
if c > maxrb { if maxrb > 0 && c > maxrb {
// Skip this number to avoid modulo bias. // Skip this number to avoid modulo bias.
continue continue
} }

5
uniuri_test.go
View File

@ -50,4 +50,9 @@ func TestNewLenChars(t *testing.T) {
} }
// Check that only allowed characters are present // Check that only allowed characters are present
validateChars(t, u, chars) validateChars(t, u, chars)
// Check that two generated strings are different
u2 := NewLenChars(length, chars)
if u == u2 {
t.Fatalf("not unique: %q and %q", u, u2)
}
} }